Framework team review #1 - Raphael Ritz (2009-02-07)
====================================================

Tested using Ubuntu and Firefox

- the review buildout builds and is functional

- added an external CSS resource in ZMI -> OK even when specifying 
  wrong values for merging and compression on add

- confirmed GS import/export support

- browsed through the code changes and didn't notice anything
  suspicious.

- browsed through the tests added and asserted reasonable coverage
  of the new fearures

- run the tests for Products.ResourceRegistries (OK)

- run the tests for Products.CMFPlone (3 failures and 0 errors
  unrelated to this PLIP - UnicodeSplitter/testNormalizeLatin1
  ./testProcessLatin1 and TestPortalCreation/testEventsSubTopic)




Comments
--------

- I propose to add some documentation paragraph to the config page 
  in ZMI as this would help generating awareness of the features.

- When adding an external resource with a dysfunctional URL (e.g.
  because of a typo) you are not made aware of this.
  Would be great if this could be detected and signalled somehow.

- Up to now Plone itself isn't using the new features: this should
  be changed at least for the IE fixes (remove inclusion from main 
  template and add them to the registry instead).

- In cases where we ship with 3rd party resources unchanged (JS libraries 
  mainly I guess) Plone could start now pulling them in from trusted
  sources per default (see Alex' comment on the PLIP page).


UI impact
---------

None for people using Plone's basic CMS features.
Some for admins/integrators (see above)

Documentation impact
--------------------

Everywhere where we explain the RRs we should check and potentially
update to introduce teh new features.


Overall impression
------------------

Good work providing two new and useful features.
Thanks to all who contributed but to Michael Dunlap in particular!


Conclusion
----------

As Plone's adoption of the new features isn't strictly necessary for
acceptance of this PLIP I'm +1 although I would appreciate if my first
two comments above could be addressed.